Create dynamical-tj-nwp.yaml#3155
Merged
Merged
Conversation
cstner
requested changes
Jun 10, 2026
cstner
left a comment
cstner
left a comment
Contributor
There was a problem hiding this comment.
Everything looks good except that for the Browse Bucket link using AWS S3 Explorer: https://github.com/awslabs/aws-js-s3-explorer - you need to deploy the index.html file from AWS S3 Explorer to the root of your bucket so the link will work
cstner
requested changes
Jun 10, 2026
cstner
left a comment
cstner
left a comment
Contributor
There was a problem hiding this comment.
Also, can you give AWS (the upstream maintainers) the ability to modify your pull request per these instructions? https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork
Contributor
Author
|
Hi @cstner , Thank you for your review and suggestions!
Please let me know if there are any other modifications needed. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Draft registration for TianJi Weather TJ-NWP dataset
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.